chore: adopt planning-convention (fresh adopt at v1.0.0)#20
Merged
Conversation
Apply lesnik512/planning-convention as a fresh adopt:
- Copy planning/index.py and planning/_templates/* verbatim from the
canonical repo.
- Add planning/README.md with the portable Quick-path + Conventions prose
plus repo-local Index/Other sections.
- Scaffold planning/{changes,decisions,releases}/, planning/deferred.md, and
architecture/README.md (promotion rule).
- Justfile: add `index` and `check-planning` recipes; run the validator as a
lint-ci step.
- CLAUDE.md: add a Workflow pointer to the Quick path and the architecture/
promotion reminder.
- Record applied version in planning/.convention-version (1.0.0).
Verified: `just check-planning` prints `planning: OK`; `just lint-ci` passes.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Author one architecture/ file per public capability, grounded in the current source, following the modern-di architecture/ layout: - retry.md, connections.md, dsn.md, transaction.md, settings.md - architecture/README.md: capability index + promotion rule - CLAUDE.md: ## Architecture becomes quick orientation + a symbol→file table pointing at architecture/ as authoritative Corrects two CLAUDE.md inaccuracies while promoting the prose: - target_session_attrs is overwritten by build_db_dsn from use_replica (dict union); honoring a pre-existing value happens in build_connection_factory. - Transaction.__aexit__ always closes the session, in addition to the in-transaction auto-rollback. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies
lesnik512/planning-conventionto this repo as a fresh adopt at v1.0.0 (no priorplanning/.convention-version), following the canonicalAPPLY.mdflow.What landed
planning/index.py,planning/_templates/{change,design,plan,decision,release}.md.planning/README.md— portable Quick-path + Conventions, with repo-local## Index/## Othersections and a pointer to.convention-version.planning/{changes,decisions,releases}/,planning/deferred.md,architecture/README.md(states the promotion rule).Justfile: newindexandcheck-planningrecipes;lint-cinow runsplanning/index.py --check.CLAUDE.md:## Workflowpointer to the Quick path + thearchitecture/promotion reminder.planning/.convention-version=1.0.0.Applied CHANGELOG delta
date/slugderived from names), Quick-path on-ramp,_templates/, and thearchitecture/promotion rule.Verification
just check-planning→planning: OKjust lint-ci→ passes (eof-fixer, ruff format/check, ty, planning validator)🤖 Generated with Claude Code